This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add FMA4 support in binutils


On Mon, Jul 6, 2009 at 9:49 AM, rajagopal,
dwarak<dwarak.rajagopal@amd.com> wrote:
>> Then please put back the exact assembler/disassembler patches
>> I reverted since they were tested extensively. Please pay attentions
>> to white spaces/blank lines and avoid long comment lines.
>>
>
> I can't use the exact same patches as it includes removal of vpermilp*
> and also addition of Intel FMA instructions. I have used the same code
> wherever possible since they are already extensively tested as you
> mentioned.
>
> I have corrected white spaces/blank lines and long comments in my
> patches.
> Is this Ok? I'm currently testing it.
>

Please add a blank line at

 }
<<<<<<<<<<<<<Here
+/* Get the VEX immediate byte without moving codep.  */
+
+static unsigned char
+get_vex_imm8 (int sizeflag)
+{

OK with that change.

Thanks.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]