This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: large file support on solaris


Nick Clifton wrote:
Hi Nathan,

2009-03-31 Nick Clifton <nickc@redhat.com>

    PR 9992
    * configure.in: Import Solaris specific largefile test from
    bfd/configure.in.
    * configure: Regenerate.

Is there a reason you didn't apply this to the other configure.in files (gas, ld, gprof) in binutils?

Because the problem was that the size of the fields in the stat structure vary depending upon whether largefile support is enabled or not, and the only situation I could find where a stat structure was passed between differently configured pieces of code was when various files in the binutils/ sub-directory called the bfd_stat_arch_elt function in the bfd library.

yup, that's the bug I found :)


Without applying everywhere we can get inconsistent setting of _FILE_OFFSET_BITS.

Does this introduce any bugs ?


Note - I do not have any objection to copying the largefile test into the configure files in those directories, I would just like to know if it is going to fix a real problem.

At the moment, I don't know -- I'm investigating. I'm not sure whether ino_t is exposed via a bfd header for instance. I'll let you know what I find.


nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]