This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: merge src and gcc copies of dwarf2.h

>>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:

>> +  tem = ((unsigned int) loc->dw_loc_opc << 1) | loc->dtprel;
>> +  CHECKSUM (tem);

Ian> This appears to change the checksum, which probably doesn't matter too
Ian> much, but since it can appear in a .o file it seems to me that we might
Ian> as well keep the same checksum, as in
Ian>   tem = (loc->dtprel << 8) | ((unsigned int) loc->dw_loc_opc);

Oops, I did not realize this could end up in the .o.

Ian> This patch is OK for gcc with that change.

Thanks.  I made this change and will check it in soon.
I'll post the corresponding src patch sometime soon.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]