This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] always treat "simple obcopy of an executable" test as XFAIL on cygwin


Christopher Faylor wrote:
> On Thu, Jun 25, 2009 at 06:17:09PM +0100, Dave Korn wrote:
>> Christopher Faylor wrote:
>>> Just checked this in after checking with Dave Korn that it made sense.
>>  Argh.  Except that when I got round to testing it natively, it has a side
>> effect:
> 
> I carefully inspected that file, noticed the similar mingw test, made
> the wrong decision, and then tested the wrong set of files.

  :-/  I carefully inspected your patch, saw that it was correctly setting up
an xfail for cygwin among a whole bunch of other xfails, and completely forgot
to check that it was going in the right place!  It reminded me that when
dealing with a patch generated without -p I should always apply it and read
the resulting file instead of just trying to inspect the patch on its own.

> I moved the test to copy_executable.

  All fixed now.  Thanks!

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]