This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix readelf -sI (or -a)

Hi John,

+	  free (gnubuckets);
+	  if (do_using_dynamic)
+	    return 0;
+	  gnubuckets = NULL;


It would be safer to set gnubuckets to NULL immediately after free()ing.
Allowing 'return' between "free (gnubuckets);" and "gnubuckets = NULL;"
allows bugs to propagate, and possibly making future maintenance more costly.

A fair point. It would also be better to move the return to after the "ngnubuckets = 0" statement, so I have done that and checked in the patch with this changelog entry.

Cheers
  Nick

binutils/ChangeLog
2009-06-12  John Reiser  <jreiser@BitWagon.com>

	* readelf.c (process_symbol_table): Set gnubuckets to NULL after
	freeing it and before returning.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]