This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix the plugin search in some file systems

From: Ian Lance Taylor <iant at google dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: binutils at sourceware dot org, Nick Clifton <nickc at redhat dot com>, TÃrÃk Edwin <edwintorok at gmail dot com>
Date: Fri, 05 Jun 2009 08:19:43 -0700
Subject: Re: [patch] Fix the plugin search in some file systems
References: <38a0d8450906050428i285f2e03ne61ebdfc31919191@mail.gmail.com> <m3ab4msqbv.fsf@google.com> <38a0d8450906050753j233cd291sa4948fefd80a6ab8@mail.gmail.com>

Rafael Espindola <espindola@google.com> writes:

>> Some operating systems do not provide a d_type field at all. ÂThe
>> binutils should be highly portable. ÂYou should only check the d_type
>> field if a configure check shows that it is present.
>
> Is there an existing check already?

Not that I know of, but it would be easy to add.

> If not I think it is best to just take the
> performance hit and always stat the file. Would that be ok?

No opinion.  If the performance hit is only when a --plugin option is
used, it doesn't seem too important.

Ian

Follow-Ups:
- Re: [patch] Fix the plugin search in some file systems
  - From: Rafael Espindola

References:
- [patch] Fix the plugin search in some file systems
  - From: Rafael Espindola
- Re: [patch] Fix the plugin search in some file systems
  - From: Ian Lance Taylor
- Re: [patch] Fix the plugin search in some file systems
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]