This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c

From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: binutils at sourceware dot org, Masaki Muranaka <monaka at monami-software dot com>
Date: Mon, 11 May 2009 00:35:33 +0100
Subject: Re: [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
References: <174A04C6-C668-4EA9-9942-723613A8A7EE@monami-software.com> <200905101723.04185.vapier@gentoo.org>

Mike Frysinger wrote:
> On Saturday 09 May 2009 23:03:18 Masaki Muranaka wrote:
>> There are some redundant ATTRIBUTE_UNUSEDs in elf32-bfin.c
>> These may be harmless but should be fixed for trusted code.
> 
> sorry, but how are they redundant ?
> -mike

  It looks to me like they are redundant because the argument in question is,
in fact, used, after all, probably as a result of the code evolving since the
prototype for the function was first written.  Given that we have -Werror,
surely if this compiles it must be correct?

    cheers,
      DaveK

Follow-Ups:
- Re: [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
  - From: Mike Frysinger

References:
- [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
  - From: Masaki Muranaka
- Re: [Patch] redundant ATTRIBUTE_UNUSED in elf32-bfin.c
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]