This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gold patch rfa] fix output after short writes


Elliott send this to me while discussing another issue.  Seems
nearly-obvious to me.

Tested by modifying tweaking gold to trigger the problem case: changed
Output_file::map to always use anonymous regions for output (to force
writes), and changed Output_file::close to call a fake write function
(instead of the real write function) that truncated large writes.

Ran the testsuite on gold tweaked as described above with this patch
(i686-linux), and then again on a copy of gold with *only* this patch.


chris
----
[gold/ChangeLog]
2008-04-23  Elliott Hughes  <enh@google.com>

        * output.cc (Output_file::close): After short writes, continue
        writing from the correct offset in the buffer being written.

Attachment: short_write.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]