This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix PR6744 (--export-dynamic not supported on PE)
Dave Korn wrote:
> I'm just verifying that it does indeed pass on a bunch of the small embedded
> ARM/MCORE/WinCE PE targets, I'll fix any fallout but don't expect it.
Perhaps I should have thunk a bit harder and longer before I said that. I
am suitably embarrassed by this schoolboy howler. Committed as an
obvious-fix-to-own-prior-patch; the only reason I didn't leave the file empty
altogether is because I didn't want to make this become additionally a test of
the zero-size-object corner case.
Apologies to any arm-wince-pe overnight autotesters who saw an extra fail
appear. I'll drop a note to the appropriate list so nobody has to worry.
Cross-tested from linux to arm-wince-pe, which was the only platform out of
{arm-epoc-pe arm-wince-pe i386-pc-netbsdpe i386-pc-pe i586-pc-interix
i586-unknown-beospe i686-pc-cygwin i686-pc-mingw32 mcore-unknown-pe
powerpcle-unknown-pe sh-unknown-pe thumb-epoc-pe x86_64-pc-freebsd
x86_64-pc-linux-gnu x86_64-pc-mingw32} to show this failure.
ld/testsuite/ChangeLog
* ld-pe/export_dynamic_warning.s: Make dummy code portable.
cheers,
DaveK
Index: ld/testsuite/ld-pe/export_dynamic_warning.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-pe/export_dynamic_warning.s,v
retrieving revision 1.1
diff -p -u -r1.1 export_dynamic_warning.s
--- ld/testsuite/ld-pe/export_dynamic_warning.s 2 Apr 2009 14:42:41 -0000 1.1
+++ ld/testsuite/ld-pe/export_dynamic_warning.s 3 Apr 2009 06:55:52 -0000
@@ -1,5 +1,4 @@
_start:
- xor %eax,%eax
- ret
+ nop