This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output

From: Ian Lance Taylor <iant at google dot com>
To: Cary Coutant <ccoutant at google dot com>
Cc: Hans-Peter Nilsson <hp at bitrange dot com>, Binutils <binutils at sourceware dot org>
Date: Fri, 27 Mar 2009 07:46:47 -0700
Subject: Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output
References: <c17be2b30903251700v3a3b9c27j57ee92e0cc9c3b5c@mail.gmail.com> <20090325200743.D15751@dair.pair.com> <c17be2b30903251726i3ce35bdh32407f00ef1ef6dd@mail.gmail.com> <20090326145641.GA14087@caradoc.them.org> <c17be2b30903261132h6b96d8e1s6cad35f3883c0fb1@mail.gmail.com>

Cary Coutant <ccoutant@google.com> writes:

> +                gold_assert(parameters->
> +                  options().output_is_position_independent());
>  		check_non_pic(object, r_type);

I can see the path you took to get to this patch, but now that you are
here, why not just put the assert in check_non_pic in all cases?

Ian

Follow-Ups:
- Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output
  - From: Cary Coutant

References:
- [gold][patch] Fix non-PIC warning to print only when building position-independent output
  - From: Cary Coutant
- Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output
  - From: Hans-Peter Nilsson
- Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output
  - From: Cary Coutant
- Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output
  - From: Daniel Jacobowitz
- Re: [gold][patch] Fix non-PIC warning to print only when building position-independent output
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]