This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Silence ld auto-import warnings for pe-i386.
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 26 Feb 2009 15:10:20 +0000
- Subject: Re: [PATCH] Silence ld auto-import warnings for pe-i386.
- References: <49A6A10B.4030000@gmail.com> <49A6AA58.7060509@gmail.com>
Dave Korn wrote:
> Dave Korn wrote:
>
>> Tested natively on i686-pc-cygwin with no regressions
>
> Argh, how did I miss that? There is one new FAIL, ld-pe/.secrel32, which
> has a mismatch in the objdump output owing to the fact that .rdata is now
> being placed in .data. I'll have a follow-on patch to adjust the .d file so
> that the regexps match the new output shortly.
Attached. Rather than try and match two different patterns of section
assignment on different targets according to default auto-import behaviour, I
just disable it for the test. OK if other patch is OK?
ld/testsuite/ChangeLog
* ld-pe/pe.exp: Disable auto-import when linking on Cygwin.
cheers,
DaveK
Index: ld/testsuite/ld-pe/pe.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-pe/pe.exp,v
retrieving revision 1.8
diff -p -u -r1.8 pe.exp
--- ld/testsuite/ld-pe/pe.exp 6 Aug 2007 14:41:51 -0000 1.8
+++ ld/testsuite/ld-pe/pe.exp 26 Feb 2009 14:58:39 -0000
@@ -34,6 +34,11 @@ if {[istarget x86_64-*-mingw*] } {
{".secrel32" "" "" {secrel1.s secrel2.s}
{{objdump -s secrel_64.d}} "secrel.x"}
}
+} elseif {[istarget i*86-*-cygwin*] } {
+ set pe_tests {
+ {".secrel32" "--disable-auto-import" "" {secrel1.s secrel2.s}
+ {{objdump -s secrel.d}} "secrel.x"}
+ }
} else {
set pe_tests {
{".secrel32" "" "" {secrel1.s secrel2.s}