This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Your checkin broke elf32-arm.c, at least with -Werror for gcc-4.1.2
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: christophe dot lyon at st dot com
- Cc: binutils at sourceware dot org
- Date: Tue, 24 Feb 2009 00:22:24 +0100
- Subject: Your checkin broke elf32-arm.c, at least with -Werror for gcc-4.1.2
Your latest checkin caused a warning when compiled with
gcc-4.1.2 (F 8 on x86_64), but bfd is compiled with -Werror, as
observed by my autotester building arm-sim:
2009-02-20 Christophe Lyon <christophe.lyon@st.com>
* elf32-arm.c (stub_insn_type): New type.
(stub_reloc_type): Likewise.
(insn_sequence): Likewise.
...
...
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/tmp/hpautotest-sim/src/bfd -I. -I. -I/tmp/hpautotest-sim/src/bfd -I/tmp/hpautotest-sim/src/bfd/../include -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c /tmp/hpautotest-sim/src/bfd/elf32-arm.c -o elf32-arm.o
cc1: warnings being treated as errors
/tmp/hpautotest-sim/src/bfd/elf32-arm.c: In function 'arm_map_one_stub':
/tmp/hpautotest-sim/src/bfd/elf32-arm.c:11699: warning: 'sym_type' may be used uninitialized in this function
make[4]: Leaving directory `/tmp/hpautotest-sim/arm-elf/bfd'
make[4]: *** [elf32-arm.lo] Error 1
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/hpautotest-sim/arm-elf/bfd'
make[2]: make[2]: Leaving directory `/tmp/hpautotest-sim/arm-elf/bfd'
*** [all] Error 2
make[1]: *** [all-bfd] Error 2
make[1]: Leaving directory `/tmp/hpautotest-sim/arm-elf'
make: *** [all] Error 2
And for ChangeLog's, you should write the date of the commit
(i.e. 2009-02-23), not something else like presumably the
posting date of the patch (2009-02-20).
brgds, H-P