This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch - hppa] add compile time check for immediate values of
- From: Helge Deller <deller at gmx dot de>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: binutils at sourceware dot org, dave dot anglin at nrc dot ca, amodra at bigpond dot net dot au
- Date: Sun, 22 Feb 2009 21:41:02 +0100
- Subject: Re: [Patch - hppa] add compile time check for immediate values of
- References: <20090222203211.51B8B4ECF@hiauly1.hia.nrc.ca>
John David Anglin wrote:
>> +/* Store immediate values of shift/deposit/extract functions. */
>> +
>> +#define SAVE_IMMEDIATE(VALUE) \
>> + { \
>> + if (immediate_check) \
>> + { \
>> + if (pos == -1) \
>> + pos = VALUE; \
>> + else \
>> + if (len == -1) \
>> + len = VALUE; \
>> + } \
>> + }
>
> Another minor tweak. Put parentheses around the uses of "VALUE".
Ok.
> It's ok to have "else if" on one line.
Ok.
> However, body of the first
> if should be indented. The only exception to that rule is case
> statements.
It is indented, but with tab which is why it maybe looked wrong.
Anyway, I'll respin :-)
> The patch is ok with that change.
Thanks!
Helge