This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Add --identify-strict option to dlltool; Handle ms-style implibs [Was: --identify-ms]


Nick Clifton wrote:
> Hi Chuck,
> 
>> 2008-01-09  Charles Wilson  <...>
>>
>>     Add --identify-strict option. Handle ms-style implibs.
>>
> 
> Approved and applied (with a few small formatting fixes).

Thanks! I'm sorry about the formatting problems; I thought I had
maintained the appropriate style fairly well, but it looks like I was
badly mistaken. :-(

The following is not a proposal for new functionality, but looking over
the --identify and --identify-strict options, I now notice that I can
make a few small changes and avoid using these global variables:
  identify_ms
  identify_member_contains_symname_result
  identify_dll_name_list_head
  identify_dll_name_list_tail
by passing custom structs as the userdata to the iteration functions.
Would that cleanup patch be worth (my) effort?

--
Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]