Re: [patch]: make idata$4 and .idata$5 more compliant to coff spec

[Kai Tietz <Kai dot Tietz at onevision dot com>]

"Kai Tietz" <ktietz70@googlemail.com> wrote on 06.01.2009 17:54:50:

> 2009/1/6 Nick Clifton <nickc@redhat.com>:
> > Hi Kai,
> >
> >> Ok, how should I name it?
> >> For dlltool maybe the option --prefixed-import-tables and same for 
ld?
> >
> > Using the same name for both tools is a good idea.  I would suggest a
> > slightly more informative name though.  How about
> > --use-nul-prefixed-import-tables ?
> >
> > Cheers
> >  Nick
> >

So the patch got a bit bigger as before, but now with option 
--use-nul-prefixed-import-tables for dlltool and ld (pe targets).

ChangeLog

2009-01-07  Kai Tietz  <kai.tietz@onevision.com>

        * dlltool.c (use_nul_prefixed_import_tables): New.
        (make_head): Make prefix leading zero prefix element for
        idata$4 and idata$5 dependent to new flag.
        (usage): Add new option  --use-nul-prefixed-import-tables.
        (OPTION_USE_NUL_PREFIXED_IMPORT_TABLES): New.
        (long_options): Add --use-nul-prefixed-import-tables.
        (main): Likewise.
        * doc/binutils.texi: Add new option documentation for
        --use-nul-prefixed-import-tables.

2009-01-07  Kai Tietz  <kai.tietz@onevision.com>

        * pe.em (OPTION_USE_NUL_PREFIXED_IMPORT_TABLES): New.
        (gld..._add_options): Add new option
        --use-nul-prefixed-import-tables.
        (gld..._handle_option): Likewise.
        * pep.em: Same as for pe.em.
        * ld.texinfo: Add new option documentation for
        --use-nul-prefixed-import-tables.
        * pe-dll.c (pe_use_nul_prefixed_import_tables): New.
        (make_head): Make prefix leading zero prefix element for
        idata$4 and idata$5 dependent to new flag.
        (make_import_fixup_entry): Remove idata4/5 prefix.
        * pe-dll.h (pe_use_nul_prefixed_import_tables): New.
        * pep-dll.c (pe_use_nul_prefixed_import_tables): New.
        * pep-dll.h (pep_use_nul_prefixed_import_tables): New.

I tested this patch on i686-pc-cygwin and for x86_64-pc-mingw32 targets 
without regressions.

Is this patch ok for apply?

Cheers,
Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: pe_idata45.diff
Description: Binary data