This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Make sure that $ characters are prefixed by backslash

On Sun, 4 Jan 2009, Dave Korn wrote:

Kai Tietz wrote: 

Thanks for catching this.
Updated patch ok for apply?

Also, I think you don't need to escape the ones inside single-quotes:

@@ -1636,7 +1636,7 @@ gld_${EMULATION_NAME}_place_orphan (asec

  /* Look through the script to see where to place this section.  */
  if (!link_info.relocatable
-      && (dollar = strchr (secname, '$')) != NULL)
+      && (dollar = strchr (secname, '\$')) != NULL)


I'm pretty sure that, in C, a dollar sign may not be escaped by a slash.
The result of an invalid escape sequence
is implementation-defined or an error.
Many implementations simply ignore the backslash.

--
Michael   hennebry@web.cs.ndsu.NoDak.edu
"Pessimist: The glass is half empty.
Optimist:   The glass is half full.
Engineer:   The glass is twice as big as it needs to be."

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]