This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch]: Fix base-file and relocation for w64
- From: Andreas Schwab <schwab at suse dot de>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, binutils at sourceware dot org, NightStrike at gmail dot com
- Date: Wed, 01 Oct 2008 17:20:20 +0200
- Subject: Re: [patch]: Fix base-file and relocation for w64
- References: <OF38FD7A63.055F6FDD-ONC12574D5.0041311A-C12574D5.0042CEEC@onevision.de>
Kai Tietz <Kai.Tietz@onevision.com> writes:
> @@ -1584,18 +1584,18 @@ dump_def_info (FILE *f)
> static int
> sfunc (const void *a, const void *b)
> {
> - return *(const long *) a - *(const long *) b;
> + return (int) (*(const bfd_vma *) a - *(const bfd_vma *) b);
This will overflow.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."