This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH gold/6859] Symbols specified as -u <symbol> may erroneously get added to dynsym
- From: Ian Lance Taylor <iant at google dot com>
- To: Kris Van Hees <kris dot van dot hees at oracle dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 26 Aug 2008 12:07:17 -0700
- Subject: Re: [PATCH gold/6859] Symbols specified as -u <symbol> may erroneously get added to dynsym
- References: <20080529205212.GQ13586@oracle.com> <20080826140138.GA16080@oracle.com> <20080826141248.GB16080@oracle.com>
Kris Van Hees <kris.van.hees@oracle.com> writes:
> 2008-08-26 Kris Van Hees <kris.van.hees@oracle.com>
>
> PR 6859
> * symtab.cc (Symbol::init_base_undefined): Mark explicitly undefined
> symbols as not needing a dynsym entry.
>
> Patch:
> ======
> Index: gold/symtab.cc
> ===================================================================
> RCS file: /cvs/src/src/gold/symtab.cc,v
> retrieving revision 1.107
> diff -r1.107 symtab.cc
> 176a177
>> this->dynsym_index_ = -1;
Please write -1U. This is OK with that change.
By the way, diffs are easier to understand if you generate them with
-up or plain -p.
Thanks.
Ian