This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] mips_frob_file -- fix hi/lo pairings
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Fu\, Chao-Ying" <fu at mips dot com>
- Cc: "Catherine Moore" <clm at codesourcery dot com>, <binutils at sourceware dot org>, "Lau\, David" <davidlau at mips dot com>
- Date: Fri, 27 Jun 2008 09:04:02 +0100
- Subject: Re: [patch] mips_frob_file -- fix hi/lo pairings
- References: <94BD67F8AF3ED34FA362C662BA1F12C501007DE4@MTVEXCHANGE.mips.com>
"Fu, Chao-Ying" <fu@mips.com> writes:
> Richard Sandiford wrote:
>>
>> Richard Sandiford <rdsandiford@googlemail.com> writes:
>> > "Fu, Chao-Ying" <fu@mips.com> writes:
>> >> Index: mips16-hilo-match.d
>> >> ===================================================================
>> >> RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips16-hilo-match.d,v
>> >> retrieving revision 1.1
>> >> diff -u -p -r1.1 mips16-hilo-match.d
>> >> --- mips16-hilo-match.d 9 May 2008 19:28:47 -0000 1.1
>> >> +++ mips16-hilo-match.d 19 Jun 2008 22:02:25 -0000
>> >> @@ -1,4 +1,5 @@
>> >> #objdump: -r
>> >> +#as: -march=mips1
>> >> #name: MIPS16 mips16-hilo-match
>> >>
>> >> .*: +file format .*mips.*
>> >
>> > You'd need to make that "-mabi=32 -march=mips16", for targets that
>>
>> Err, I meant -march=mips1, of course. ;)
>>
>
> Yes. Is this patch ok?
Looks good to me FWIW, although I can't approve it.
I'd be tempted to apply it under the obviously-correct rule,
but I suppose revised patches are never truly obvious.
Richard