This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ping] [patch] ARM support for long calls

Hi Christophe,

I have found a few issues with my patch,

Sorry - this is partially my fault. I should never have accepted your first patch without checking for regressions in the linker testsuite. If I had done that and encountered the new failures I would have rejected the patch and insisted that they be fixed first.

and here is attached the corresponding fix.

Thanks very much for creating this fix.

	bfd/
	* elf32-arm.c (arm_type_of_stub): Ignore STT_SECTION symbols.
	(elf32_arm_stub_add_mapping_symbol): Remove.
	(elf32_arm_add_stub): Don't generate mapping symbols. Change
	prototype.
	(elf32_arm_size_stubs): Use new elf32_arm_add_stub
	prototype. Don't generate thumb to arm glue for calls.
	(arm_map_one_stub): Define.
	(elf32_arm_output_arch_local_syms): Generate mapping symbols for
	long calls stubs.
	
	ld/testsuite/
	* ld-arm/farcall-arm-arm.s: Force function type on 'bar'.
	* ld-arm/farcall-thumb-arm.s: Likewise.
	* ld-arm/farcall-thumb-arm-blx.d: Fix encoding.
	* ld-arm/farcall-thumb-arm.d: Likewise.
	* ld-arm/farcall-thumb-arm-blx-pic-veneer.d: Likewise.
	* ld-arm/arm-elf.exp (armelftests): Add farcall-mix, farcall-mix2,
	farcall-group-default, farcall-group-size2, farcall-section Ignore
	gas warnings in farcall-thumb-arm, farcall-thumb-arm-blx,
	farcall-thumb-arm-blx-pic-veneer.

Approved and applied.

Cheers
  Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]