This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Don't check FMA for instructions with immediate operand

From: Daniel Jacobowitz <drow at false dot org>
To: David Miller <davem at davemloft dot net>
Cc: hjl dot tools at gmail dot com, binutils at sourceware dot org
Date: Fri, 18 Apr 2008 23:55:16 -0400
Subject: Re: PATCH: Don't check FMA for instructions with immediate operand
References: <6dc9ffc80804181122r458ec15ege12b26154f64b4d3@mail.gmail.com> <20080418.141901.218914281.davem@davemloft.net>

On Fri, Apr 18, 2008 at 02:19:01PM -0700, David Miller wrote:
> From: "H.J. Lu" <hjl.tools@gmail.com>
> Date: Fri, 18 Apr 2008 11:22:10 -0700
> 
> > I am checking in this patch to avoid checking FMA for instructions
> > with immediate operand.
> 
> H.J. please combine several changelog entry headers for the same day.
> 
> You don't need to specify the date and all that other stuff over and
> over again when it's going to be the same.

Why prefer this?  I know some developers use this style, but a lot of
others don't - I personally find it much clearer to see what was
committed in each separate patch.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- PATCH: Don't check FMA for instructions with immediate operand
  - From: H.J. Lu
- Re: PATCH: Don't check FMA for instructions with immediate operand
  - From: David Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]