This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][m68k] Support generation of multiple GOTs


thank you for the review. Below are my comments.

Andreas Schwab wrote:
Maxim Kuvyrkov <> writes:


+               [GOT handling scheme (target, single, negative, multigot)]),
+[case "${enableval}" in
+  target | single | negative | multigot)  got_handling=$enableval ;;
+  *)  AC_ERROR(bad value ${enableval} for --enable-got option) ;;

I don't think we need that configure option. Passing the right option by default via gcc should be enough.

I thought of that, but the choice of the default setting is really dependent on the glibc version installed on a particular system. This is due to glibc's dynamic linker making assumptions about GOT pointer. Hence I introduced the configure option.

I'll fix all other issues you pointed out.

Also I forgot to attach new test files for the ld-m68k testsuite in my original message. Here they are.


Attachment: got-tests.tar.bz2
Description: Binary data

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]