This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch 1/2] Add demangling for java resource files to libiberty
- From: Ian Lance Taylor <iant at google dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, binutils at sourceware dot org, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 18 Jan 2008 11:45:54 -0800
- Subject: Re: [Patch 1/2] Add demangling for java resource files to libiberty
- References: <478C061B.1040003@avtrex.com>
David Daney <ddaney@avtrex.com> writes:
> 2008-01-14 David Daney <ddaney@avtrex.com>
>
> * demangle.h (demangle_component_type): Add
> DEMANGLE_COMPONENT_JAVA_RESOURCE,
> DEMANGLE_COMPONENT_COMPOUND_NAME, and
> DEMANGLE_COMPONENT_CHARACTER as new enum values.
> (demangle_component): Add struct s_character to union u.
>
> libiberty/
> 2008-01-14 David Daney <ddaney@avtrex.com>
>
> * cp-demangle.c (d_dump): Handle DEMANGLE_COMPONENT_JAVA_RESOURCE,
> DEMANGLE_COMPONENT_COMPOUND_NAME, and
> DEMANGLE_COMPONENT_CHARACTER cases.
> (d_make_comp): Handle DEMANGLE_COMPONENT_COMPOUND_NAME and
> DEMANGLE_COMPONENT_JAVA_RESOURCE cases.
> (d_make_character): New function.
> (d_java_resource_part): Same.
> (d_java_resource): Same.
> (d_special_name): Handle "Gr" case.
> (d_print_comp): Handle DEMANGLE_COMPONENT_JAVA_RESOURCE,
> DEMANGLE_COMPONENT_COMPOUND_NAME, and
> DEMANGLE_COMPONENT_CHARACTER cases.
> (testsuite/demangle-expected): Add test for java resource name
> mangling.
This patch is OK. It is OK for gcc 4.3 if the other part of the patch
(to libjava) is committed to gcc 4.3. Otherwise please wait until
after the 4.3 release branch is made.
> + while (d_peek_char(di))
Please add a space before the left parenthesis.
Thanks.
Ian