This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Xtensa] add a 32-bit PC-relative relocation


Bob Wilson wrote:
This patch adds a new R_XTENSA_32_PCREL relocation along with GAS support to generate it. Committed.

I found a small problem with this change and fixed it with the following patch. I also fixed an obvious cut-and-paste error that I stumbled upon in a debugging function.


2007-12-12 Bob Wilson <bob.wilson@acm.org>

        * elf32-xtensa.c (elf_xtensa_do_reloc): Update self_address along with
        address.
        (print_action_list): Fix name for ta_convert_longcall.
Index: elf32-xtensa.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-xtensa.c,v
retrieving revision 1.103
diff -u -p -r1.103 elf32-xtensa.c
--- elf32-xtensa.c	7 Dec 2007 22:52:09 -0000	1.103
+++ elf32-xtensa.c	12 Dec 2007 20:18:45 -0000
@@ -1575,6 +1575,7 @@ elf_xtensa_do_reloc (reloc_howto_type *h
 
 	/* The CALL needs to be relocated.  Continue below for that part.  */
 	address += 3;
+	self_address += 3;
 	howto = &elf_howto_table[(unsigned) R_XTENSA_SLOT0_OP ];
       }
       break;
@@ -4846,7 +4847,7 @@ print_action_list (FILE *fp, text_action
 	case ta_remove_longcall:
 	  t = "remove_longcall"; break;
 	case ta_convert_longcall:
-	  t = "remove_longcall"; break;
+	  t = "convert_longcall"; break;
 	case ta_narrow_insn:
 	  t = "narrow_insn"; break;
 	case ta_widen_insn:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]