This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix DWARF for ia64

Here is a follow-on patch. I noticed that dwarf2_emit_label() can also use the new dwarf2_consume_line_info function.

Is this OK?

I forgot to say how I tested this. I built binutils for xtensa-elf, ia64-unknown-linux-gnu and i686-pc-linux-gnu targets, all hosted on i686-pc-linux-gnu, and ran the testsuite. I've rerun those tests now with this follow-on patch. Everything passed as expected with one exception: the ld-ia64/line.exp test fails but I see the same failure without any of my changes. ld fails to show the source line number in an error message. That does seem suspicious. Is this a known problem?

	* dwarf2dbg.c (dwarf2_emit_label): Use dwarf2_consume_line_info.

--- dwarf2dbg.c.2	2007-11-13 12:41:33.000000000 -0800
+++ dwarf2dbg.c	2007-11-13 12:42:42.000000000 -0800
@@ -419,17 +419,11 @@
   if (debug_type == DEBUG_DWARF2)
     dwarf2_where (&loc);
-    {
-      loc = current;
-      dwarf2_loc_directive_seen = FALSE;
-    }
+    loc = current;
   loc.flags |= DWARF2_FLAG_BASIC_BLOCK;
-  current.flags &= ~(DWARF2_FLAG_BASIC_BLOCK
+  dwarf2_consume_line_info ();
   dwarf2_gen_line_info_1 (label, &loc);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]