This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [rfc, v2] Fix ELF synthetic symbol size bug (affects PPC64)
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org, amodra at bigpond dot net dot au
- Date: Tue, 6 Nov 2007 16:44:02 -0500
- Subject: Re: [rfc, v2] Fix ELF synthetic symbol size bug (affects PPC64)
- References: <200711052014.lA5KEiTm019854@d12av02.megacenter.de.ibm.com> <200711062133.lA6LX4nq031372@d12av02.megacenter.de.ibm.com>
On Tue, Nov 06, 2007 at 10:33:04PM +0100, Ulrich Weigand wrote:
> Alan suggested a way to pass that information: have the udata.p
> member of the synthetic symbol point back to the full ELF symbol
> structure of the original symbol used to derive the synthetic
> symbol from. The patch below implements this.
>
> Tested (GDB) on powerpc64-linux, fixes another 12 FAILs on top
> of the ones already fixed by the original patch.
>
> Is the bfd part OK?
The elf.c part of this does not make sense to me. Why should we have
the same size as that symbol? The @plt entry is only a couple of
instructions. To figure out its size you need to ask the backend
plt_sym_val routine.
--
Daniel Jacobowitz
CodeSourcery