This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch to detect invalid mergeable string sections

From: Alan Modra <amodra at bigpond dot net dot au>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: binutils at sourceware dot org
Date: Mon, 5 Nov 2007 14:29:10 +1030
Subject: Re: Patch to detect invalid mergeable string sections
References: <Pine.LNX.4.64.0710301609020.7201@digraph.polyomino.org.uk> <20071030225501.GF5706@bubble.grove.modra.org> <Pine.LNX.4.64.0710311806580.31492@digraph.polyomino.org.uk> <20071101071111.GE11924@bubble.grove.modra.org> <20071105021205.GG11924@bubble.grove.modra.org> <Pine.LNX.4.64.0711050229570.21619@digraph.polyomino.org.uk>

On Mon, Nov 05, 2007 at 02:31:18AM +0000, Joseph S. Myers wrote:
> On Mon, 5 Nov 2007, Alan Modra wrote:
> 
> > ld/testsuite/
> > 	* ld-elf/merge3.d, ld-elf/merge3.s: Delete.
> 
> It seems to me tests are still needed to make sure the linker doesn't 
> crash (or indeed to verify that the unterminated strings now get properly 
> merged).

That could be quite challenging.  A meaningful test should fail on a
20071031 ld and pass with today's ld.  I think you'd need to replace
ld's memory allocation functions with ones that filled memory with
some non-zero pattern, or run ld under valgrind or somesuch to
reliably detect an error caused by buffer overrun.

-- 
Alan Modra
Australia Development Lab, IBM

References:
- Re: Patch to detect invalid mergeable string sections
  - From: Alan Modra
- Re: Patch to detect invalid mergeable string sections
  - From: Alan Modra
- Re: Patch to detect invalid mergeable string sections
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]