This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/5149: Set PF_X for PT_GNU_RELRO segment only when needed
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 24 Oct 2007 15:25:59 +0930
- Subject: Re: PATCH: PR ld/5149: Set PF_X for PT_GNU_RELRO segment only when needed
- References: <20071022223109.GA14599@lucon.org>
On Mon, Oct 22, 2007 at 03:31:09PM -0700, H.J. Lu wrote:
> PR ld/5149
> * elf.c (assign_file_positions_for_non_load_sections): Set
> PF_X for PT_GNU_RELRO segment only if a section has
> SHF_EXECINSTR.
I took a look at what glibc ld.so does with PT_GNU_RELRO and it
appears that p_flags are completely ignored. The mprotect call
always uses PROT_READ. So I don't really see the point of this
patch.
--
Alan Modra
Australia Development Lab, IBM