This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] another discarded DWARF issue

On Mon, Oct 15, 2007 at 10:11:58PM -0700, Bob Wilson wrote:
> I did that at first but then read the comment describing the rawsize  
> field: "it is currently only set for sections where the linker  
> relaxation scheme doesn't cache altered section and reloc contents  
> (stabs, eh_frame, SEC_MERGE, some coff relaxing targets), and thus  
> the original size needs to be kept to read the section multiple times."
> The Xtensa port _does_ cache the altered section contents and  
> currently does not set rawsize.  I started changing it to set rawsize  
> but this comment made me think that perhaps that was the wrong  
> approach.  I guess not, since there doesn't seem to be another good  
> way to get the unrelaxed size of a section.  Unless you have other  
> suggestions, I'll apply the patch with your change, and then fix up  
> the Xtensa port to set rawsize.

I think that this is the right way to go.  You might like to update
the rawsize comment while you're at it.

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]