This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?

From: msnyder at sonic dot net
To: "Jie Zhang" <jzhang918 at gmail dot com>
Cc: "Michael Snyder" <msnyder at sonic dot net>, "Andreas Schwab" <schwab at suse dot de>, binutils at sourceware dot org
Date: Wed, 5 Sep 2007 11:49:56 -0700 (PDT)
Subject: Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
References: <14767.12.7.175.2.1188953629.squirrel@webmail.sonic.net><9329.12.7.175.2.1188955779.squirrel@webmail.sonic.net> <jey7flwjzf.fsf@sykes.suse.de> <001501c7efca$cf09b2a0$677ba8c0@sonic.net> <46DEDA73.9080503@gmail.com>

> Michael Snyder wrote:
>>> msnyder@sonic.net writes:
>>>
>>>>> As far as I can tell, there is no such thing as R_BFIN_GOT12...
>>>>>
>>>>> 2007-09-04  Michael Snyder  <msnyder@access-company.com>
>>>>>
>>>>>         * elf32-bfin.c (howto_table): Cut and paste error?
>>>>>         Name field of reloc is wrong.
>>>> And now that I think about it -- isn't the "bitsize" field
>>>> wrong too?  Shouldn't it be 18?
>>> bitsize is the size after shifting.
>>
>> Fair enough.   And what about the actual patch?
>>
> The patch is OK. I'm sure it's a cut and paste error. Thanks!

Thanks, committed.

References:
- bfd/elf32-bfin.c: Possible typo or cut/paste error?
  - From: msnyder
- Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
  - From: msnyder
- Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
  - From: Andreas Schwab
- Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
  - From: Michael Snyder
- Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
  - From: Jie Zhang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]