RE: libiconv for windres

[Kai Tietz <Kai dot Tietz at onevision dot com>]

Hi Danny,

> Kai,  I do appreciate the work you've done on this. However there 
> are several problems in winduni.c 
> that prevent compilation for windows target.
Sorry, I changed (and copy and paste) without recompiling. Thanks for 
correcting it, I applied to the patch in attachment.

> I am not 100% certain of correct dwFlags for WideCharToMultiByte but
> considering the problems with some codepages (eg UTF-7)and non-
> default flags for invalid chars, I think the safest thing is to just
> use default flags for now, rather than always use '_' as substitute 
> for invalid chars.
Me too. But I detected by practice, that dwFlags with value zero works 
very fine, but I changed it to your suggestion.

> There are some secutity issues with input buffer sizes that need to be 
tested
>  http://msdn2.microsoft.com/en-us/library/ms776406.aspx
> I haven't looked at these in your patch yet.  Perhaps you already have 
done.
Yes, but I think we will have no problems about this here.
> 
> I assume that the currently unused funcions in your winduni.c have a
> use in your message compiler. Is that correct? 

That's right. I introduced the API needed for the windmc-tool. But also I 
think the missing "-c" option can be implemented by this methods to 
windres, too.

Cheers,
 i.A. Kai Tietz



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer: 
Ulrike DÃhler, Manuela Kluger

Attachment: wind_uni.txt
Description: Text document