This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: patch: windres allows string concat
- From: Nick Clifton <nickc at redhat dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: binutils at sourceware dot org, "'Danny Smith'" <dannysmith at clear dot net dot nz>, Dave Korn <dave dot korn at artimi dot com>, Brian Dessent <brian at dessent dot net>
- Date: Thu, 24 May 2007 10:24:40 +0100
- Subject: Re: patch: windres allows string concat
- References: <OFFD58A2F2.F58DD87F-ONC12572E5.002F8B4A-C12572E5.0033149B@onevision.de>
Hi Kai,
This patch allows that "rc"-parser joins strings for style's CAPTION,
CLASS, FONT (names), and for menu elements MENUITEM & POPUP, and also for
version VALUE text elements.
Did you test this patch ? If so, how ?
[As a general point you should always test patches and always report how
you tested them. Eg in this case by rerunning the binutils testsuite
for windres using toolchain and showing that there are no regressions].
Also, since you are adding a new feature, it would be a good idea if you
could add a new testcase to check it.
Cheers
Nick