This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix ppc64_elf_adjust_dynamic_symbol
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 7 May 2007 12:32:35 +0930
- Subject: Re: [PATCH] Fix ppc64_elf_adjust_dynamic_symbol
- References: <20070506193052.GX1826@sunsite.mff.cuni.cz>
On Sun, May 06, 2007 at 09:30:52PM +0200, Jakub Jelinek wrote:
> Looking many other backends the if (h->type == STT_FUNC || h->needs_plt)
> block always ends with return TRUE, except in elf64-ppc.c.
> Is there any reason for that?
Did you try running the ld testsuite natively after applying your
patch? :-) Yes, there is good reason. We might need copy relocs
(or at least get to the ELIMINATE_COPY_RELOCS code so that we clear
non_got_ref and generate a dyn reloc) for function descriptors, which
are STT_FUNC.
--
Alan Modra
IBM OzLabs - Linux Technology Centre