sim build failures (was Re: use <sys/int_types.h> instead of <stdint.h> on Solaris...)snapshot binutils-2.17.50)

[Hans-Peter Nilsson <hp at bitrange dot com>]

On Tue, 24 Apr 2007, Alan Modra wrote:

> 	* sysdep.h: Don't include ansidecl.h here.

This bit caused problems for some simulators, which include the
bfd sysdep.h (some from CGEN-generated files), without including
ansidecl.h before.  At least the following target simulators now
fail building: sh64-elf, sh-elf, cris-elf, d10v-elf, with errors
like the following (cutnpastenmunged):

gcc -c -DHAVE_CONFIG_H   -DWITH_DEFAULT_MODEL='"crisv32"'
-DPROFILE=1 -DWITH_PROFILE=-1
-DWITH_ALIGNMENT=NONSTRICT_ALIGNMENT  \
 -DWITH_ENVIRONMENT=ALL_ENVIRONMENT  -DWITH_HW=0
-DWITH_HOST_BYTE_ORDER=LITTLE_ENDIAN     -DWITH_SCACHE=16384
-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses
-Wpointer-arith -Wuninitialized       -I.
-I/h/hp/sim/cvs_latest/src/sim/cris -I../common -I/h/hp/sim/cvs_latest/src/sim/cris/../common
-I../../include
-I/h/hp/sim/cvs_latest/src/sim/cris/../../include -I../../bfd -I/h/hp/sim/cvs_latest/src/sim/cris/../../bfd
-I../../opcodes
-I/h/hp/sim/cvs_latest/src/sim/cris/../../opcodes  -g -O2 \
/h/hp/sim/cvs_latest/src/sim/cris/cris-desc.c
In file included from
/h/hp/sim/cvs_latest/src/sim/cris/cris-desc.c:25:
/h/hp/sim/cvs_latest/src/sim/cris/../../bfd/sysdep.h:124: error:
expected '=', ',', ';', 'asm' or '__attribute__' before 'malloc'

or:
In file included from
/mnt/4/hp/axis/simwrite/src/sim/sh64/sh-desc.c:25:
/mnt/4/hp/axis/simwrite/src/bfd/sysdep.h:124: error: syntax
error before "malloc"
/mnt/4/hp/axis/simwrite/src/bfd/sysdep.h:124: error: conflicting
types for `malloc'
/usr/include/stdlib.h:556: error: previous declaration of
`malloc'

Just as a heads-up.  I plan on fixing it within a few weeks. :-P

I'm undecided about actually complaining about the bfd sysdep.h
change.  Its name seemed dependable as the first #include in any
.c file generated or not, but maybe not?

brgds, H-P