This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: windres
On Mon, Apr 23, 2007 at 01:58:52PM +0200, Kai Tietz wrote:
>Hello,
>
>This is my suggested patch for replacing the windres resource file lexer.
>The lexer has the same feature set as the prior one, but also supports
>underscores, dollars, and digits in resource identifiers.
>
>ChangeLog:
>
>2007-04-23 Kai Tietz <Kai.Tietz@onevision.com>
>
> * binutils/rclex.c: New file.
> * binutils/rclex.l: Remove file.
> * binutils/Makefile.am: Replaced rclex.l by rclex.c.
> * binutils/Makefile.in: Regenerated.
I'm sorry that I missed this before but what was the rationale for
replacing the (f)lex file with a .c file? That seems like a step backwards
to me.
You also have \r\n endings in the file that you provided. It's a minor
issue but, as long as I'm here...
cgf