Re: [PATCH] add --reverse option to objcopy

[Nathan Froyd <froydnj at codesourcery dot com>]

On Fri, Apr 20, 2007 at 02:32:56PM +0100, Nick Clifton wrote:
>   * H.J. pointed out that the name of the switch is slightly confusing.
>     --reverse-endian or --reverse-bytes might be a more reasonable
>     name.

I have changed the option to --reverse-bytes in the code and the
documentation.

>   * I think that this paragraph in the documentation is rather
>     confusing:
> 
> +By using @samp{--reverse=2} followed by @samp{--reverse=4}, then bytes
> +ordered @code{34127856} would be generated.
> 
>     To me this implied that you can use the --reverse switch twice on 
> the same command line in order to achieve the effect you describe.  If I 
> have read the code correctly however, only the last instance of the 
> switch on the command line will be honored, and so you need to run the 
> objcopy command *twice* in order to achieve the desired effect.

Yes, that's not particularly clear.  I have altered the paragraph to
make it more obvious that you need to run the command twice.

>   * The code should check to see if --reverse if issued more than once 
> on the command line and (if they have different values) warn the user 
> that the earlier value(s) are being ignored.

Done.

OK?

-Nathan

Attachment: reverse.patch
Description: Text document