Re: PATCH: windres

[Kai Tietz <Kai dot Tietz at onevision dot com>]

"H. J. Lu" <hjl@lucon.org> wrote on 13.04.2007 16:41:06:

> > Nightmares, ... 8| I begun to modify structure using character arrays 
... 
> > I come to the point, that this means for big parts of windres better a 

> > complete rewrite. Structures with internal/external scope and data 
> > modifications are really wired.
> > May we should first use my last patch, so that the problem is solved, 
and 
> > then I will begin to reorganize the windres tool to be host 
idependent. By 
> > this I can add some missing resource types to it.
> > 
> > What do you think about my suggestion to continue ?
> > 
> 
> That is fine with me. If you do this, you don't need to handle
> endian and just replace long with int since you will rewrite it
> later anyway.

This is the patch changing the windres source using int instead of long. I 
bootstrap it on cygwin 32 and for x86_64-mingw.
This patch does not solve the endian problem, reasoned by the use of 
fwrite/fread.
ChangeLog for binutils/:

2007-04-16  Kai Tietz  <Kai.Tietz@onevision.com>

        * rclex.l: Replace long by int usage.
        * rcparse.y: Likewise.
        * resbin.c: Likewise.
        * rescoff.c: Likewise.
        * resrc.c: Likewise.
        * resres.c: Likewise.
        * windres.h: Likewise.
        * windres.c: Likewise.
        (main): Add assert if sizeof int has not 4 byte
        size.


Regards,
 i.A. Kai Tietz



------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer: 
Ulrike DÃhler, Manuela Kluger

Attachment: windres_int.txt
Description: Text document