This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: support '# line "file" flags' and '# 0 "" 2'
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 9 Mar 2007 00:02:51 +1030
- Subject: Re: support '# line "file" flags' and '# 0 "" 2'
- References: <orodn5a5os.fsf@free.oliva.athome.lsd.ic.unicamp.br>
On Wed, Mar 07, 2007 at 04:11:47AM -0300, Alexandre Oliva wrote:
> numbering, introducing .linefile (because .line was already taken in
> + constant, and turns the # in # <number> <filename> <garbage> into a
> + .line. This needs better error-handling. */
Please fix the comment. Please also fix the do_scrub_chars state
machine comments. Hmm, it seems to me that you could remove
state 7 from the machine with this change too. Any simplification
would be welcome. That chunk of code gives me a headache any time I
look at it. ;-)
Otherwise looks OK to me.
--
Alan Modra
IBM OzLabs - Linux Technology Centre