This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gprof] disjoint histograms

From: Daniel Jacobowitz <drow at false dot org>
To: Vladimir Prus <vladimir at codesourcery dot com>
Cc: Nick Clifton <nickc at redhat dot com>, Ben Elliston <bje at au1 dot ibm dot com>, binutils at sourceware dot org
Date: Fri, 23 Feb 2007 06:52:50 -0500
Subject: Re: [gprof] disjoint histograms
References: <200702121049.23365.vladimir@codesourcery.com> <1172191857.7213.5.camel@localhost> <45DE9AD2.4090702@redhat.com> <200702231115.50817.vladimir@codesourcery.com>

On Fri, Feb 23, 2007 at 11:15:50AM +0300, Vladimir Prus wrote:
> I certainly can update both NEWS and gprof.texi and post a new patch.
> I'll do that in a couple of days provided no objections to the
> code patch itself will show up.

It looks fine to me, except for two things: one "// FIXME" and two places
where you use malloc or realloc instead of xmalloc / xrealloc.  You
can also delete the casts of the malloc return value - now that we
assume c89 they're no longer necessary.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- [gprof] disjoint histograms
  - From: Vladimir Prus
- Re: [gprof] disjoint histograms
  - From: Ben Elliston
- Re: [gprof] disjoint histograms
  - From: Nick Clifton
- Re: [gprof] disjoint histograms
  - From: Vladimir Prus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]