This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gprof] disjoint histograms


Hi Daniel, Hi Vladimir

On Mon, Feb 12, 2007 at 10:49:23AM +0300, Vladimir Prus wrote:
The attached patch makes gprof support histogram records
will different memory ranges, provided those memory ranges
never overlap. This is done by adding new structure, 'struct histogram'
adding a linked list of such structures and modifying gprof to use this
linked list.

Did anyone have comments on this patch, or objections? Otherwise, I'll review it myself in a few days.

The patch seems good to me. Unless Daniel has any criticisms then I have no objections to approving it.


My one suggested addition would be that you could add an entry in the binutils/NEWS file mentioning this new feature of gprof.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]