This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Enable 64bit emulation if available
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 10 Feb 2007 04:19:11 +1030
- Subject: Re: PATCH: Enable 64bit emulation if available
- References: <20070209172939.GA7006@lucon.org>
On Fri, Feb 09, 2007 at 09:29:39AM -0800, H. J. Lu wrote:
> --- ld/configure.tgt.wrap 2007-01-08 09:28:56.000000000 -0800
> +++ ld/configure.tgt 2007-02-04 16:46:07.000000000 -0800
> @@ -167,10 +167,8 @@ i[3-7]86-*-linux*aout*) targ_emul=i386li
> i[3-7]86-*-linux*oldld) targ_emul=i386linux; targ_extra_emuls=elf_i386 ;;
> i[3-7]86-*-linux-*) targ_emul=elf_i386
> targ_extra_emuls=i386linux
> - if test x${want64} = xtrue; then
> - targ_extra_emuls="$targ_extra_emuls elf_x86_64"
> - targ_extra_libpath=elf_x86_64
> - fi
> + targ64_extra_emuls="$targ_extra_emuls elf_x86_64"
> + targ64_extra_libpath=elf_x86_64
Please don't add targ_extra_emuls to targ64_extra_emuls here and other
places in this file. You add them in configure.in. I know this
doesn't matter, but it's messy. Please also explicitly initialise
target64_extra_{emuls,libpath} to empty at the start of configure.tgt
and add a comment for them in the block describing shell variables.
OK with those changes.
--
Alan Modra
IBM OzLabs - Linux Technology Centre