This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/3966: 32bit address wrap around doesn't work with 32bit host
On Wed, Feb 07, 2007 at 12:27:32AM +1030, Alan Modra wrote:
> On Sun, Feb 04, 2007 at 03:19:39PM -0800, H. J. Lu wrote:
> > To support ia32 address wrap around, we need 64bit BFD. This patch
> > enables 64bit BFD for ia32.
>
> I don't like this. Instead, let's not warn until we wrap to a
> section that has non-zero size.
> + && dot >= (r->last_os->output_section_statement
> + .bfd_section->vma))
It is hard to read when a field is split into 2 lines.
H.J.
---
2007-02-06 H.J. Lu <hongjiu.lu@intel.com>
* ldlang.c (lang_size_sections_1): Don't split field.
--- ld/ldlang.c.dot 2007-02-06 08:06:07.000000000 -0800
+++ ld/ldlang.c 2007-02-06 08:07:35.000000000 -0800
@@ -4467,8 +4467,7 @@ lang_size_sections_1
|| (r->last_os == NULL
&& os->bfd_section->vma != os->bfd_section->lma)
|| (r->last_os != NULL
- && dot >= (r->last_os->output_section_statement
- .bfd_section->vma)))
+ && dot >= (r->last_os->output_section_statement.bfd_section->vma)))
&& os->lma_region == NULL
&& !link_info.relocatable)
r->last_os = s;