This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS gas: Fix broken relocation sorting

David Daney wrote:
> Richard Sandiford wrote:
> >
> >Thus if we were indeed converting R_MIPS_GOT16 relocations against
> >local symbols into R_MIPS_GOT16 relocations against global symbols,
> >(1) would be the right fix.  But like I say, the bug appears at
> >first glance to be in pic_need_relax.
> >
> 
> New version of the patch:
> 
> Tested as before with mipsel-linux cross build no regressions.
> 
> OK to commit?
> 
> If this looks better, I will restart my gcc-4.2 boot strap with this 
> instead.
> 
> gas:
> 2006-11-06  David Daney  <ddaney@avtrex.com>
> 
> 	* config/tc-mips.c (pic_need_relax): Return true for section symbols.
> 
> gas/testsuite:
> 2006-11-06  David Daney  <ddaney@avtrex.com>
> 
> 	* gas/mips/elf-rel26.s: New test.
> 	* gas/mips/elf-rel26.d: Ditto.
> 	* gas/mips/mips.exp: Run it.

Ok.


Thiemo
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]