[patch/rfc] new configure option for bfd for inserting vendor version info

[Mike Frysinger <vapier at gentoo dot org>]

this simple patch adds a new flag to bfd's configure so people (like 
distributions or companies making their own releases) can easily insert a 
little bit of their own info into the --version output ... this is akin to 
gcc's VERSUFFIX in gcc/version.h, except the binutils is a bit more stream 
lined ...

comments ?  good idea/bad idea/waste-of-time ?
-mike

Attachment: pgp00000.pgp
Description: PGP signature

--- bfd/configure.in
+++ bfd/configure.in
@@ -63,6 +63,12 @@ if test $use_secureplt = true; then
     [Define if we should default to creating read-only plt entries])
 fi
 
+AC_ARG_WITH(vendor-tag,
+[  --with-vendor-tag=TAG   Include TAG in version output],
+[VENDOR_TAG="${withval}"],[VENDOR_TAG=""])dnl
+AC_SUBST(VENDOR_TAG)
+
+
 AM_BINUTILS_WARNINGS
 
 AM_CONFIG_HEADER(config.h:config.in)
--- bfd/Makefile.am
+++ bfd/Makefile.am
@@ -954,10 +954,16 @@ DISTCLEANFILES = $(BUILD_CFILES) $(BUILD
 bfdver.h: $(srcdir)/version.h $(srcdir)/Makefile.in
 	@echo "creating $@"
 	@bfd_version=`echo "$(VERSION)" | sed -e 's/\([^\.]*\)\.*\([^\.]*\)\.*\([^\.]*\)\.*\([^\.]*\)\.*\([^\.]*\).*/\1.00\2.00\3.00\4.00\5/' -e 's/\([^\.]*\)\..*\(..\)\..*\(..\)\..*\(..\)\..*\(..\)$$/\1\2\3\4\5/'` ;\
-	bfd_version_string="\"$(VERSION)\"" ;\
+	if test "x$(VENDOR_TAG)" != x ; then \
+	  vendor_tag=" $(VENDOR_TAG)" ;\
+	else \
+	  vendor_tag="" ;\
+	fi ;\
 	if test "x$(RELEASE)" = x ; then \
 	  bfd_version_date=`sed -n -e 's/.*DATE //p' < $(srcdir)/version.h` ;\
-	  bfd_version_string="\"$(VERSION) $${bfd_version_date}\"" ;\
+	  bfd_version_string="\"$(VERSION) $${bfd_version_date}$${vendor_tag}\"" ;\
+	else \
+	  bfd_version_string="\"$(VERSION)$${vendor_tag}\"" ;\
 	fi ;\
 	sed -e "s/@bfd_version@/$$bfd_version/" -e "s/@bfd_version_string@/$$bfd_version_string/" < $(srcdir)/version.h > $@