This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: gas SEGV reporting an error + patch
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Mat Hostetter <mat at lcs dot mit dot edu>
- Cc: bug-binutils at gnu dot org, binutils at sourceware dot org
- Date: Mon, 17 Jul 2006 22:20:10 +0930
- Subject: Re: gas SEGV reporting an error + patch
- References: <7u7j2k3po7.fsf@ld-1.internal.tilera.com>
On Tue, Jul 11, 2006 at 03:30:16PM -0400, Mat Hostetter wrote:
> The bug is that 'report_op_error' incorrectly uses 'file' and 'line'
> in the 'else' case where they are not initialized. Because the value
> of 'file' is garbage, it is of course somewhat random whether you will
> see a crash.
>
> The fix is trivial: since there is no location information available,
> use 'as_bad' instead of 'as_bad_where', as it was already doing for
> other errors in the 'else' case.
Applied. Thanks!
--
Alan Modra
IBM OzLabs - Linux Technology Centre