This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] (version 2) Change MIPS linker stubs to allow for more than 2^15 symbols.


David Daney <ddaney@avtrex.com> writes:
> ! #define MIPS_FUNCTION_STUB_SIZE(INFO) \
> !   (elf_hash_table (INFO)->dynsymcount > 65536 ? 20 : 16)

Sorry to be a pain, but as I said earlier, I really do think we should
cache the chosen stub size in mips_elf_link_hash_table (and get rid of
this macro entirely).  That will emphasise that always_size_dynamic_sections
is the place that makes the decision, and that it's only safe to use this
value once that function has been called.  I think that will be more robust
and easier to understand in future.

Apart from that, and from Thiemo's and Daniel's comments, this looks
really good to me.  Thanks a lot for doing this!

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]