This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix gas/1948 -- Duplicate .comm symbols
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: amodra at bigpond dot net dot au (Alan Modra)
- Cc: binutils at sources dot redhat dot com
- Date: Sun, 4 Dec 2005 23:43:18 -0500 (EST)
- Subject: Re: [patch] Fix gas/1948 -- Duplicate .comm symbols
> I don't think you need the #if.
I removed the #if and rechecked the change on hppa2.0w-hp-hpux11.11. I
also tested the change with a build and check on hppa-unknown-linux with
no regressions.
Ok?
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
2005-12-04 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
Bug gas/1948
* symbols.c (colon): Also check if now_seg is bss_section when a symbol
is being redefined.
Index: symbols.c
===================================================================
RCS file: /cvs/src/src/gas/symbols.c,v
retrieving revision 1.71
diff -u -3 -p -r1.71 symbols.c
--- symbols.c 17 Nov 2005 07:29:28 -0000 1.71
+++ symbols.c 5 Dec 2005 04:01:18 -0000
@@ -376,6 +376,7 @@ colon (/* Just seen "x:" - rattle symbol
&& S_IS_EXTERNAL (symbolP))
|| S_GET_SEGMENT (symbolP) == bss_section)
&& (now_seg == data_section
+ || now_seg == bss_section
|| now_seg == S_GET_SEGMENT (symbolP)))
{
/* Select which of the 2 cases this is. */