This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/1567: 64-bit vma overflow signalled from 32-bit-target address-wrap
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>,binutils at sources dot redhat dot com
- Date: Mon, 7 Nov 2005 12:39:19 +1030
- Subject: Re: PATCH: ld/1567: 64-bit vma overflow signalled from 32-bit-target address-wrap
- References: <20051028163715.GA15488@lucon.org> <200510281701.j9SH1Lnk016863@ignucius.se.axis.com> <20051028171007.GA16056@lucon.org> <20051028171625.GA16208@lucon.org>
On Fri, Oct 28, 2005 at 10:16:25AM -0700, H. J. Lu wrote:
> PR ld/1567
> * reloc.c (_bfd_relocate_contents): Support 32bit target with
> 64bit bfd_vma when checking complain_overflow_bitfield.
I don't think there is any point to this patch. The real bug, which
Hans-Peter fixed, is using complain_overflow_bitfield on a reloc that
is the same width as the address size. Presumably the intention is
that such relocs should never overflow, because
complain_overflow_bitfield would allow the entire address range. So
simply using complain_overflow_dont is the correct solution.
--
Alan Modra
IBM OzLabs - Linux Technology Centre