This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] GAS supports for MIPS32 MT ASE
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Chao-ying Fu <fu at mips dot com>
- Cc: Eric Christopher <echristo at apple dot com>,"Thekkath, Radhika" <radhika at mips dot com>,Thiemo Seufer <ths at networkno dot de>, binutils at sourceware dot org
- Date: Mon, 29 Aug 2005 10:55:03 +0100 (BST)
- Subject: Re: [patch] GAS supports for MIPS32 MT ASE
- References: <001401c5aa8a$3f2698b0$a914a8c0@MIPS.COM>
On Fri, 26 Aug 2005, Chao-ying Fu wrote:
> Could you review this patch? We will revise the patch, if there are issues.
Posting patches inline helps commenting significantly... Cutting &
pasting for now.
*** 220,229 ****
{"andi", "t,r,i", 0x30000000, 0xfc000000, WR_t|RD_s, 0,
/* b is at the top of the table. */
/* bal is at the top of the table. */
- {"bc0f", "p", 0x41000000, 0xffff0000, CBD|RD_CC, 0,
- {"bc0fl", "p", 0x41020000, 0xffff0000, CBL|RD_CC, 0,
- {"bc0t", "p", 0x41010000, 0xffff0000, CBD|RD_CC, 0,
- {"bc0tl", "p", 0x41030000, 0xffff0000, CBL|RD_CC, 0,
{"bc1any2f", "N,p", 0x45200000, 0xffe30000, CBD|RD_CC|FP_S, 0,
{"bc1any2t", "N,p", 0x45210000, 0xffe30000, CBD|RD_CC|FP_S, 0,
{"bc1any4f", "N,p", 0x45400000, 0xffe30000, CBD|RD_CC|FP_S, 0,
--- 223,228 ----
A comment is missing about the instructions having been relocated (like
one for "b" and "bal" seen immediately above!).
--- 1351,1415 ----
{"subu_s.qb", "d,s,t", 0x7c000150, 0xfc0007ff, WR_d|RD_s|RD_t,
{"wrdsp", "s", 0x7c1ffcf8, 0xfc1fffff, RD_s|DSP_VOLA, 0,
{"wrdsp", "s,8", 0x7c0004f8, 0xfc1e07ff, RD_s|DSP_VOLA, 0,
+ /* MIPS MT ASE Instructions. */
+ {"dmt", "", 0x41600bc1, 0xffffffff, TRAP,
+ {"dmt", "t", 0x41600bc1, 0xffe0ffff, TRAP|WR_t, 0,
+ {"dvpe", "", 0x41600001, 0xffffffff, TRAP,
Note that the table is meant to be sorted alphabetically (except from
when conflicts arise)...
--- 14359,14367 ----
-mdsp generate DSP instructions\n\
-mno-dsp do not generate DSP instructions\n"));
fprintf (stream, _("\
+ -mt generate MT instructions\n\
+ -mno-mt do not generate MT instructions\n"));
+ fprintf (stream, _("\
-mfix-vr4120 work around certain VR4120 errata\n\
-mfix-vr4130 work around VR4130 mflo/mfhi errata\n\
-mgp32 use 32-bit GPRs, regardless of the chosen ISA\n\
Hmm, there is an inconsistency here -- I think "-mmt/-mno-mt" sounds
better than "-mt/-mno-t".
dmt
dmt $0
dvpe
dvpe $1
Testing "dmt" with a non-$0 argument might be a bit more useful to
assure `objdump' gets the disassembly right for the single-operand
variation.
I'll leave the rest to the maintainers...
Maciej