This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Thumb2 gas fixes
- From: Richard Earnshaw <rearnsha at gcc dot gnu dot org>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 05 Aug 2005 10:04:24 +0100
- Subject: Re: [patch] Thumb2 gas fixes
- References: <200508041504.42731.paul@codesourcery.com>
On Thu, 2005-08-04 at 15:04, Paul Brook wrote:
> The attached patch fixed 4 thumb2 gas bugs:
>
> - Immediate operands allow shifted 8-bit constants, unlike arm which allows
> rotated constants.
> - ALU operations do not allow shift by register operands.
> - Incorrect encoding of shifted index addressing modes.
> - Incorrect encoding of ldm and stm instructions
>
> Tested on arm-none-eabi.
> Ok?
>
> Paul
>
> 2005-08-04 Paul Brook <paul@codesourcery.com>
>
> gas/
> * config/tc-arm.c (encode_thumb32_immediate): Only accept shifted
> constants.
> (encode_thumb32_shifted_operand): Prohibit register shifts.
> (encode_thumb32_addr_mode): Fix typo.
> (insns): Correct thumb2 ldm and stm opcodes.
> gas/testsuite/
> * gas/arm/thumb32.d: Update ldm/stm dests.
> * gas/arm/thumb32.s: Ditto.
OK.